Skip to content

Update cli.py / device_manager.py to use get_home_data_v3 and discovered Roborock Q10 devices #418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 10, 2025
Merged

Update cli.py / device_manager.py to use get_home_data_v3 and discovered Roborock Q10 devices #418

merged 5 commits into from
Aug 10, 2025

Conversation

lboue
Copy link
Contributor

@lboue lboue commented Jul 17, 2025 •
edited
Loading

Use get_home_data_v3 to discovered Roborock Q10 devices

I was able to discover my Q10 device after cloning this repo (36f5f2b) and changing to v3 :

(venv) user@vm:~/roborock/python-roborock/python-roborock$ python -m roborock.cli discover
Discovered devices Roborock Q10 S5+
(venv) user@vm:~/roborock/python-roborock/python-roborock$ python -m roborock.cli list-devices
Known devices Roborock Q10 S5+: 1simZp7ZguuihAICo*****

@lboue lboue changed the title Update cli.py to use get_home_data_v3 anddiscovered Roborock Q10 devices Update cli.py to use get_home_data_v3 and discovered Roborock Q10 devices Jul 17, 2025
@lboue lboue changed the title Update cli.py to use get_home_data_v3 and discovered Roborock Q10 devices Update cli.py / device_manager.py to use get_home_data_v3 and discovered Roborock Q10 devices Jul 17, 2025
@lboue lboue marked this pull request as ready for review July 17, 2025 16:04
@lboue lboue mentioned this pull request Jul 17, 2025
Open
allenporter
allenporter requested changes Jul 18, 2025
View reviewed changes
Copy link
Contributor

@allenporter allenporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two problems:
(1) Commit style is not matching the expected commit style. Please amend the last commit with feat: XXX and force push
(2) The tests are not passing with this change

@lboue
Copy link
Contributor Author

lboue commented Jul 18, 2025

Two problems:
(1) Commit style is not matching the expected commit style. Please amend the last commit with feat: XXX and force push

Thanks. I will check that.

(2) The tests are not passing with this change

Perhaps the version needs to be adapted to the device model.

@allenporter
Copy link
Contributor

(2) The tests are not passing with this change

Perhaps the version needs to be adapted to the device model.

It's because the test mocks out the get home data call and the call changed to be a different call. The test just needs to be updated to match the other call.

@lboue
feat: get_home_data_v3 for new devices
07f1530 
Use get_home_data_v3 to discovered Roborock Q10 devices
Update device_manager.py to use get_home_data_v3
@lboue lboue force-pushed the get_home_data_v3 branch from e017988 to 07f1530 Compare July 30, 2025 19:13
@lboue
Copy link
Contributor Author

lboue commented Jul 30, 2025 •
edited
Loading

Two problems:

  • (1) Commit style is not matching the expected commit style. Please amend the last commit with feat: XXX and force push

Fixed now

(2) The tests are not passing with this change

I updated the tests.

@lboue lboue requested a review from allenporter July 30, 2025 19:44
allenporter
allenporter previously approved these changes Aug 10, 2025
View reviewed changes
@allenporter allenporter requested a review from Lash-L August 10, 2025 18:37
Lash-L
Lash-L approved these changes Aug 10, 2025
View reviewed changes
Copy link
Collaborator

@Lash-L Lash-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Completely fine using v3 - but just to temper expectations, this makes t get discovered, but it can't actually fully integrate yet

@Lash-L Lash-L merged commit 98ea911 into Python-roborock:main Aug 10, 2025
6 checks passed
@lboue lboue deleted the get_home_data_v3 branch August 10, 2025 18:57
@lboue
Copy link
Contributor Author

lboue commented Aug 10, 2025

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lash-L Lash-L Lash-L approved these changes

@allenporter allenporter allenporter left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lboue @allenporter @Lash-L